This repository has been archived by the owner on Feb 10, 2024. It is now read-only.
src/common/url.c : issue #2507 add UTF Cyrillic support in nicknames #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmikita
changed the title
kmikita
changed the title
|
The entire client is broken with non-ascii nicks, so I don't think it makes sense to change tiny details like this to support them. |
|
Ideally, the entire range of UTF should be passed, but I was only add the Cyrillic alphabet as this solves a particular annoying issue #2705. I don't see any stability or performance hindrance in the use of non-ASCII characters. |
|
It can work if the server only does ascii comparisons for nicks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some servers, for example RusNET, the use of Cyrillic characters in nicknames is allowed, which leads to issue #2507.