-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move allocation logic to rust #1835
Conversation
9ff4f18
to
a9beab0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIce
router/src/block_allocator.rs
Outdated
window_size: Option<u32>, | ||
) -> Self { | ||
// Create channel | ||
let (sender, receiver) = mpsc::unbounded_channel(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to the PR, but maybe it's a culprit for the leaks.
https://docs.rs/tokio/latest/tokio/sync/mpsc/fn.unbounded_channel.html
a9beab0
to
e346b6d
Compare
e346b6d
to
9410a79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Close #2007