Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check that warmup_setps is either 0 or >= 1 #30764

Merged
merged 5 commits into from
May 23, 2024

Conversation

ymoslem
Copy link
Contributor

@ymoslem ymoslem commented May 11, 2024

What does this PR do?

Update training_args.py to add a check that warmup_setps is either 0 or >= 1. Otherwise, raise an error.

Before submitting

Update training_args.py to add a check that warmup_setps is either 0 or >= 1. Otherwise, raise an error.
@ymoslem
Copy link
Contributor Author

ymoslem commented May 23, 2024

Hello! I am not sure what I should do to fix these errors in the tests. Thanks!

FAILED tests/models/dpt/test_modeling_dpt_auto_backbone.py::DPTModelTest::test_batching_equivalence - AssertionError: tensor(False) is not true : Batched and Single row outputs are not equal in DPTForDepthEstimation for key=predicted_depth. Difference=1.0.
================= 1 failed, 577 passed, 935 skipped in 56.07s ==================
#!/bin/bash -eo pipefail
python3 .circleci/parse_test_outputs.py --file tests_output.txt --fail

1 failed because `AssertionError: tensor(False) is not true ` -> Batched and Single row outputs are not equal in DPTForDepthEstimation for key=predicted_depth. Difference=1.0.
Number of failed tests: 1

Exited with code exit status 1

CircleCI received exit code 1

Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this check! I think the test failures are unrelated to this. cc @amyeroberts for final review :)

@muellerzr
Copy link
Contributor

You can try rebasing from main

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this check!

I think we can add another bound, to make sure the error message aligns with what's being tested

src/transformers/training_args.py Outdated Show resolved Hide resolved
ymoslem and others added 2 commits May 23, 2024 17:10
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@amyeroberts amyeroberts merged commit 892b13d into huggingface:main May 23, 2024
21 checks passed
itazap pushed a commit that referenced this pull request May 24, 2024
* Add a check that warmup_setps is either 0 or >= 1

Update training_args.py to add a check that warmup_setps is either 0 or >= 1. Otherwise, raise an error.

* Update src/transformers/training_args.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

---------

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants