-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a check that warmup_setps is either 0 or >= 1 #30764
Conversation
Update training_args.py to add a check that warmup_setps is either 0 or >= 1. Otherwise, raise an error.
Hello! I am not sure what I should do to fix these errors in the tests. Thanks!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this check! I think the test failures are unrelated to this. cc @amyeroberts for final review :)
You can try rebasing from |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this check!
I think we can add another bound, to make sure the error message aligns with what's being tested
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
* Add a check that warmup_setps is either 0 or >= 1 Update training_args.py to add a check that warmup_setps is either 0 or >= 1. Otherwise, raise an error. * Update src/transformers/training_args.py Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com> --------- Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
What does this PR do?
Update training_args.py to add a check that warmup_setps is either 0 or >= 1. Otherwise, raise an error.
Before submitting
This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
Did you read the contributor guideline,
Pull Request section?
Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
Did you write any new necessary tests?
trainer: @muellerzr and @pacman100