Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocast incompatibility in RecurrentGemma #30832

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xplip
Copy link

@xplip xplip commented May 15, 2024

What does this PR do?

Fixes #30830

In modeling_recurrent_gemma.py, cast the key_states and value_states in RecurrentGemmaSdpaAttention._update_cache to the dtype of the cache tensors they are written to. This way, a RuntimeError is prevented when autocasting to bfloat16/float16.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@amyeroberts
Copy link
Collaborator

cc @ArthurZucker

@ArthurZucker
Copy link
Collaborator

Hey, could you share a reproducer? 🤗

@xplip
Copy link
Author

xplip commented May 20, 2024

Hey, could you share a reproducer? 🤗

Sure, I added one in the issue #30830 :)

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed issue 😉
What's weird for me is that

        with torch.autocast(device_type=device_type, enabled=False):
            freqs = (inv_freq_expanded.float() @ position_ids_expanded.float()).transpose(1, 2)
            emb = torch.cat((freqs, freqs), dim=-1)
            cos = emb.cos()
            sin = emb.sin()
        return cos.to(dtype=x.dtype), sin.to(dtype=x.dtype)

is the only place we mess up with autocast. I think casting earlier should help memory, but this is overall the safest way .

Could you run the slow tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RecurrentGemma not compatible with autocast / AMP training
3 participants