Add Command + ArrowLeft/Right input behavior for macOS #2315
+83
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this also be extended to address |
|
|
Brady-Simon
force-pushed
the
macos-command-input-behavior
branch
from
24b9c74
to
e851526
Compare
hecrj
reviewed
May 3, 2024
Brady-Simon
force-pushed
the
macos-command-input-behavior
branch
from
e851526
to
5602459
Compare
hecrj
force-pushed
the
macos-command-input-behavior
branch
2 times, most recently
from
6f3225d
to
e249e56
Compare
hecrj
force-pushed
the
macos-command-input-behavior
branch
from
e249e56
to
8cfa814
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds macOS-specific behavior for the input and text editor for Command + ArrowLeft to behave like Home and Command + ArrowRight to behave like End to match the native behavior. This behavior is particularly useful for users with MacBooks since there aren't Home/End keys on the keyboard.
I added a new
platform::is_macos_command_pressedfunction instead of usingmodifiers.command()since the latter defaults to CTRL on other platforms and represents a jump instead of moving to the beginning/end of the line.This PR leaves out other shortcuts like Command + ArrowUp -- which would also move to the cursor to the beginning of the line for single line inputs and the beginning of the document for multi-line inputs -- to limit the scope of changes.