Address cv2.resize float16 issue in scale_cam_image #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christophe-Foyer
changed the title
Christophe-Foyer
changed the title
|
any chance we can merge and release? @Christophe-Foyer |
jacobgil
approved these changes
May 28, 2024
|
Merged. Thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#198
#493
Putting in a PR to go along with my issue post.
cv2.resize doesn't support float16 which causes this step to break. This fixes the issue with not downstream consequences that I can identify since the resulting image gets converted to lfoat32 anyways.