Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable timer sound #19

Open
aar0nr opened this issue Oct 12, 2017 · 7 comments
Open

Add option to disable timer sound #19

aar0nr opened this issue Oct 12, 2017 · 7 comments

Comments

@aar0nr
Copy link

aar0nr commented Oct 12, 2017

Scares me every time when my volume is set high! 😝

@karbassi
Copy link
Collaborator

Related to #49

@robinstewart
Copy link
Contributor

I've implemented a prototype which has a little inline volume control. Clicking the speaker icon cycles between 4 states: high volume, medium volume, low volume, and sound off. Each timer has its own volume, but new timers default to the volume setting last used.

Thoughts? I don't want to clutter this app's nice clean user interface, but this does seem like an important feature. Possibly in the future if we want to add more options (such as customizing alarm sounds and colors) this could be replaced by a "settings gear" icon that opens up a panel with all available options.

imageimageimageimage

@karbassi
Copy link
Collaborator

@robinstewart I do love the clean style of this and how each timer will have its own volume, but I think it might be best to have a preferences panel show up (separate from the timer) that allows you to set the volume (maybe a range?) and the sound played (related to #49 #61)

Thoughts?

@robinstewart
Copy link
Contributor

I think the main advantage of having the volume right there is that it makes it very clear whether or not a sound will play when the timer goes off. Maybe you turned off the sound last time, but today you want the sound to play to make sure you don't miss it. Without the indicator there, it would be easy to forget that the setting has been changed — a potentially dangerous situation if the timer is for an important task.

So it serves as both an indicator and a control button.

@karbassi I completely agree that a panel with more options would be great to address other feature requests. But I'm ok with considering that as separate, future work.

@karbassi
Copy link
Collaborator

@robinstewart I'm okay with that. I say we push it and change it if it's a problem later.

@robinstewart
Copy link
Contributor

I'm not sure I like this design enough yet to submit it. It would be better to have a real slide-out or pop-up panel with a volume slider, and a sleeker button icon on the main timer window, like an alert bell icon that doesn't change in size. I don't have time to do this work right now so I've just submitted #80 which is just a small back-end change which will help future efforts.

@gousern
Copy link

gousern commented Apr 22, 2021

I've implemented a prototype which has a little inline volume control. Clicking the speaker icon cycles between 4 states: high volume, medium volume, low volume, and sound off. Each timer has its own volume, but new timers default to the volume setting last used.

Thoughts? I don't want to clutter this app's nice clean user interface, but this does seem like an important feature. Possibly in the future if we want to add more options (such as customizing alarm sounds and colors) this could be replaced by a "settings gear" icon that opens up a panel with all available options.

imageimageimageimage

Very cool. Volume control function looks like what I really need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants