Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set version number for official 1.16.1 release #6138

Merged
merged 1 commit into from
May 17, 2024
Merged

Set version number for official 1.16.1 release #6138

merged 1 commit into from
May 17, 2024

Conversation

cjvolzka
Copy link
Contributor

Description

Remove "rc*" from version number in preparation for final 1.16.1 release.

Signed-off-by: Charles Volzka cjvolzka@us.ibm.com

@cjvolzka
Set version number for official 1.16.1 release
50c76f0 
### Description
Remove "rc*" from version number in preparation for final 1.16.1 release.

Signed-off-by: Charles Volzka <cjvolzka@us.ibm.com>
@cjvolzka cjvolzka added this to the 1.16.1 milestone May 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Test Results

     3 files       3 suites   2m 15s ⏱️
 7 452 tests  4 422 ✅ 3 030 💤 0 ❌
22 339 runs  13 159 ✅ 9 180 💤 0 ❌

Results for commit 50c76f0.

♻️ This comment has been updated with latest results.

@cjvolzka cjvolzka marked this pull request as ready for review May 17, 2024 17:04
@cjvolzka cjvolzka requested a review from a team as a code owner May 17, 2024 17:04
@cjvolzka cjvolzka enabled auto-merge (squash) May 17, 2024 18:03
@cjvolzka cjvolzka merged commit 52ebb5d into rel-1.16.1 May 17, 2024
69 checks passed
@cjvolzka cjvolzka deleted the set-final-1.16.1 branch May 17, 2024 18:08
@cjvolzka
Copy link
Contributor Author

@justinchuby, is there anything wrong the the CI system? The rel-1.16.1 CI failed after this merged. However they passed when this was a PR. The only change was the ONNX version number so I wouldn't expect that to cause issues reported. Even in the failing tests, it passes for some python versions but not others which also makes me think it's not related to the version number change.

Latest (most failed):

Previous (all passed):

@justinchuby
Copy link
Contributor

Looks like onnxruntime just made a new release, which broke the CIs because we are skipping based on version number 1.18; and the ops are still not supported but tests no longer skipped

@cjvolzka
Copy link
Contributor Author

Then I'm assuming the main branch is also affected the same way. Is someone working on this for main? Once that's in, I can cherry-pick the fix into the 1.16.1 release.

@justinchuby
Copy link
Contributor

I think we should pin ORT version in the CI

@liqunfu liqunfu mentioned this pull request May 22, 2024
Merged
@liqunfu
Copy link
Contributor

liqunfu commented May 22, 2024

Then I'm assuming the main branch is also affected the same way. Is someone working on this for main? Once that's in, I can cherry-pick the fix into the 1.16.1 release.

@cjvolzka, Once this is merged, please cherry-pick. thanks.
#6143

github-merge-queue bot pushed a commit that referenced this pull request May 23, 2024
@liqunfu
Pin onnxruntime to 1.17.3 for release CIs (#6143)
093a8d3 
### Description
The latest ORT 1.18.0 does not implement ML ops required for
test_backend_onnxruntime.py. Pin to the previous ort release to pass the
release CIs.

### Motivation and Context
#6138 (comment)

---------

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
cjvolzka pushed a commit that referenced this pull request May 23, 2024
@liqunfu @cjvolzka
Pin onnxruntime to 1.17.3 for release CIs (#6143)
244c7e4 
### Description
The latest ORT 1.18.0 does not implement ML ops required for
test_backend_onnxruntime.py. Pin to the previous ort release to pass the
release CIs.

### Motivation and Context
#6138 (comment)

---------

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
(cherry picked from commit 093a8d3)
@cjvolzka cjvolzka mentioned this pull request May 23, 2024
Merged
cjvolzka added a commit that referenced this pull request May 23, 2024
@cjvolzka @liqunfu
Pin onnxruntime to 1.17.3 for release CIs (#6143) (#6148)
595228d 
### Description
The latest ORT 1.18.0 does not implement ML ops required for
test_backend_onnxruntime.py. Pin to the previous ort release to pass the
release CIs.

### Motivation and Context
#6138 (comment)

---------

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
(cherry picked from commit 093a8d3)

Co-authored-by: liqun Fu <liqfu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liqunfu liqunfu liqunfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Tracker
Status: Done
Milestone
1.16.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cjvolzka @justinchuby @liqunfu