Changed How is local is checked and how serverURL is build to prevent…

[CodeTappert]

… errros in offline mode

Fixes #1078

[Admiral-Billy]

Not having the window.location.hostname === '' check breaks the offline detection for local files, such as from my app :(

[CodeTappert]

Not having the window.location.hostname === '' check breaks the offline detection for local files, such as from my app :(

You mean for compiled files? Because this change works fine when run via "npm start dev".

Even if you serve dist folder it should work without problems

[Admiral-Billy]

This is indeed back to working. Also yeah, my app is serving compiled files and registers as an empty string for that check for whatever reason; I don't know the details behind it, but that is what happens for it. My Android apk registers normally as localhost though.

[CodeTappert]

This is indeed back to working. Also yeah, my app is serving compiled files and registers as an empty string for that check for whatever reason; I don't know the details behind it, but that is what happens for it. My Android apk registers normally as localhost though.

I readded the check for you

[Admiral-Billy]

Yep, that's what I was talking about; it works fine for my app's particular offline now. Now it's just up to the actual devs to see what they think of this change for their purposes heh

[athias]

As there were minor changes to the code, I tested this again and can confirm it fixes #1078

[Admiral-Billy]

As far as I can tell, this works perfectly fine for both the dev server and my app.

[CodeTappert]

This PR is ready to be reviewed/merged by a dev.

[CodeTappert]

This PR is ready to be reviewed/merged by a dev.

Walker says this is fine. See https://discord.com/channels/1125469663833370665/1243948971110694982

[bennybroseph]

This needs some better formatting, it looks pretty bad. Please use any kind of consistency with where you're splitting up the line

[CodeTappert]

To be fair i wouldnt split the line at all....
But then it is pretty long.

[bennybroseph]

This is just a different kind of bad

[CodeTappert]

Now it is consistent and breaks after || or && if it would be to long without the break