Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Achievements localization, organized some locales files and ptBR translations #1150

Merged

Conversation

josericardo-fo
Copy link
Contributor

@josericardo-fo josericardo-fo commented May 20, 2024

Localized whole achievements screen, added some ptBR translations and organized imports, classes and languages in alphabetical order. (and added some commas in ptBR locales)

Achievements (english)

image

Locked Achievement (ptBR)

image

Achievements (ptBR)

image

Locked Achievement (ptBR)

image

@josericardo-fo josericardo-fo marked this pull request as draft May 20, 2024 06:44
@josericardo-fo
Copy link
Contributor Author

I'll be adding the achv.ts file for the other languages (english by default)

@Madmadness65 Madmadness65 added the Localization Provides or updates translation efforts label May 20, 2024
@josericardo-fo josericardo-fo marked this pull request as ready for review May 20, 2024 17:14
@josericardo-fo josericardo-fo marked this pull request as draft May 20, 2024 17:19
@josericardo-fo josericardo-fo marked this pull request as ready for review May 20, 2024 18:29
@josericardo-fo
Copy link
Contributor Author

josericardo-fo commented May 20, 2024

Ready for review. Help wanted.

@josericardo-fo josericardo-fo changed the title Achievements localization, organized some locales files and ptBR translations (Help Wanted) Achievements localization, organized some locales files and ptBR translations May 20, 2024
@josericardo-fo
Copy link
Contributor Author

Ready for commit.

@josericardo-fo josericardo-fo changed the title (Help Wanted) Achievements localization, organized some locales files and ptBR translations Achievements localization, organized some locales files and ptBR translations May 20, 2024
@Adri1
Copy link
Contributor

Adri1 commented May 21, 2024

I subbitted a French translation to your branch

@Adri1
Copy link
Contributor

Adri1 commented May 22, 2024

Made a tiny typo correction to French achiv file

French typo correction achv.ts
Copy link
Contributor

@Dakurei Dakurei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the 2 lines

import {Achv, getAchievementDescription} from "../system/achv";

and

this.descriptionText.setText(getAchievementDescription((achv as Achv).localizationKey));

for the file src/ui/achv-bar.ts are necessary, the rest is a merge error, and produces some nasty interface errors

With your erroneous changes
Screenshot_20240529_144935_Firefox

Whithout your erroneous changes
Screenshot_20240529_144547_Firefox

@CodeTappert
Copy link
Contributor

Only the 2 lines

import {Achv, getAchievementDescription} from "../system/achv";

and

this.descriptionText.setText(getAchievementDescription((achv as Achv).localizationKey));

for the file src/ui/achv-bar.ts are necessary, the rest is a merge error, and produces some nasty interface errors

With your erroneous changes
Screenshot_20240529_144935_Firefox

Whithout your erroneous changes
Screenshot_20240529_144547_Firefox

How? Like i did a merge request to his branch that did exactly what you said. (take main and only change the lines).

Didnt he merge my pr to his branch in (yet?)

@Dakurei
Copy link
Contributor

Dakurei commented May 29, 2024

He didn't merge your PR

@CodeTappert
Copy link
Contributor

He didn't merge your PR

josericardo-fo#10

Did i do.it correctly? (And yes the Voucher Thing is necessary at the description)

@Dakurei
Copy link
Contributor

Dakurei commented May 29, 2024

He didn't merge your PR

josericardo-fo#10

Did i do.it correctly? (And yes the Voucher Thing is necessary at the description)

Yes indeed, there is also the condition for the voucher description, I skipped it without paying attention 😅

Vouchers now will show the correct descrption again
@Dakurei
Copy link
Contributor

Dakurei commented May 29, 2024

Missings import at src/ui/achv-bar.ts

import { Achv } from "../system/achv";

to

import { Achv, getAchievementDescription } from "../system/achv";

@josericardo-fo
Copy link
Contributor Author

Missings import at src/ui/achv-bar.ts

import { Achv } from "../system/achv";

to

import { Achv, getAchievementDescription } from "../system/achv";

fixed

@XGSleepWalker XGSleepWalker self-assigned this May 29, 2024
XGSleepWalker
XGSleepWalker previously approved these changes May 30, 2024
@XGSleepWalker XGSleepWalker dismissed their stale review May 30, 2024 03:08

The PR still has build warnings, it will be merged once these are cleared.

Copy link
Collaborator

@XGSleepWalker XGSleepWalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the build warnings, we'll merge it then.

@josericardo-fo
Copy link
Contributor Author

@XGSleepWalker organized imports and removed duplicates

Copy link
Contributor

@returntoice returntoice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

korean locales suggested

src/locales/ko/achv.ts Outdated Show resolved Hide resolved
@XGSleepWalker XGSleepWalker merged commit c7de17a into pagefaultgames:main Jun 1, 2024
3 checks passed
@josericardo-fo josericardo-fo deleted the achievements-localization branch June 2, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localization Provides or updates translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants