Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Add option to sort results by picture title #4218

Merged
merged 1 commit into from
May 18, 2024

Conversation

wsyxbcl
Copy link
Contributor

@wsyxbcl wsyxbcl commented Apr 26, 2024

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2024

CLA assistant check
All committers have signed the CLA.

@lastzero
Copy link
Member

Thanks! Let me know when it's fully tested. I'll take a look then and merge it as soon as possible.

@wsyxbcl
Copy link
Contributor Author

wsyxbcl commented Apr 26, 2024

Thanks! Let me know when it's fully tested. I'll take a look then and merge it as soon as possible.

The function itself is already tested in my development environment. By "test case to cover" I mean it probably need to be covered in file such as folder_search_test.go as I didn't check the whole project.

Thanks for the quick response!

@wsyxbcl
Copy link
Contributor Author

wsyxbcl commented May 6, 2024

I've reviewed the test functions and found nothing else add. The code has passed the unit tests and operates as expected in my test environment. Please proceed with your review of the code.

@lastzero
Copy link
Member

Looks good to me! I'll go ahead and merge this for final testing. ✨

@lastzero lastzero merged commit 7e18a41 into photoprism:develop May 18, 2024
2 checks passed
lastzero added a commit that referenced this pull request May 18, 2024
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this pull request May 18, 2024
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero lastzero added enhancement Refactoring, improvement or maintenance task please-test Ready for acceptance test merged Changes should be tested again after they have been integrated labels May 18, 2024
@lastzero lastzero changed the title Search: Add sort by Title Search: Add option to sort by picture title May 18, 2024
@lastzero lastzero changed the title Search: Add option to sort by picture title Search: Add option to sort results by picture title May 18, 2024
@lastzero
Copy link
Member

An updated development preview build is now available for you to test these changes:

@graciousgrey graciousgrey added tested Changes have been tested successfully released Available in the stable release and removed please-test Ready for acceptance test tested Changes have been tested successfully labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Refactoring, improvement or maintenance task merged Changes should be tested again after they have been integrated released Available in the stable release
Projects
Status: Release 🌈
Development

Successfully merging this pull request may close these issues.

None yet

4 participants