-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant serialization code #126249
Conversation
|
3e08319
to
6f2652b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot revert -m 'Sorry for reverting your change but it is failing sigmoid/frontend:serialization_test internally' -c ghfirst Please take a look at the diff D57474417 for more details |
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit aab448e. Reverted #126249 on behalf of https://github.com/huydhn due to Sorry for reverting your change but it is failing sigmoid/frontend:serialization_test internally ([comment](#126249 (comment)))
@jiashenC your PR has been successfully reverted. |
After pytorch#123308, we no longer need separate serialization path to handle different types that exist in the `nn_module` metadata. This PR cleans up the redundant code. Pull Request resolved: pytorch#126249 Approved by: https://github.com/angelayi
This reverts commit aab448e. Reverted pytorch#126249 on behalf of https://github.com/huydhn due to Sorry for reverting your change but it is failing sigmoid/frontend:serialization_test internally ([comment](pytorch#126249 (comment)))
After #123308, we no longer need separate serialization path to handle different types that exist in the
nn_module
metadata. This PR cleans up the redundant code.