Remove removed ruff rule TRY200 #126256
Closed
Remove removed ruff rule TRY200 #126256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the docs: https://docs.astral.sh/ruff/rules/reraise-no-cause/ "This rule has been removed and its documentation is only available for historical reasons."
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126256
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit eac6f68 with merge base dccb5cf ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
reviewed
May 15, 2024
|
Pretty sure all the noqas will need to be adjusted too, or the original errors will need to be fixed. |
ringohoffman
requested review from
avikchaudhuri,
gmagogsfm,
tugsbayasgalan,
zhxchen17,
albanD,
jbschlosser and
mikaylagawarecki
as code owners
pytorch-bot
bot
added
module: cpu
Skylion007
reviewed
May 15, 2024
Skylion007
approved these changes
May 15, 2024
|
@Skylion007 I guess Any recommendation on these: https://github.com/pytorch/pytorch/actions/runs/9100510101/job/25019431692#step:11:243 |
Skylion007
reviewed
May 16, 2024
|
@pytorchbot merge |
Skylion007
added
better-engineering
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
manuelcandales
pushed a commit
to manuelcandales/pytorch
that referenced
this pull request
May 17, 2024
My TOML linter is complaining that "TRY200" is not acceptable for the `tool.ruff.lint` schema. From the ruff docs: https://docs.astral.sh/ruff/rules/reraise-no-cause/ > This rule has been removed and its documentation is only available for historical reasons. > > This rule is identical to [B904](https://docs.astral.sh/ruff/rules/raise-without-from-inside-except/) which should be used instead. and we are currently explicitly ignoring B904. Pull Request resolved: pytorch#126256 Approved by: https://github.com/Skylion007
|
@pytorchbot merge |
|
Can't merge closed PR #126256 |
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
May 19, 2024
Summary: My TOML linter is complaining that "TRY200" is not acceptable for the `tool.ruff.lint` schema. From the ruff docs: https://docs.astral.sh/ruff/rules/reraise-no-cause/ > This rule has been removed and its documentation is only available for historical reasons. > > This rule is identical to [B904](https://docs.astral.sh/ruff/rules/raise-without-from-inside-except/) which should be used instead. and we are currently explicitly ignoring B904. X-link: pytorch/pytorch#126256 Approved by: https://github.com/Skylion007 Reviewed By: huydhn Differential Revision: D57518709 fbshipit-source-id: f2885bbb17309a5cd71f0ad7da7533c62e2e6fe7
ZelboK
pushed a commit
to ZelboK/pytorch
that referenced
this pull request
May 19, 2024
My TOML linter is complaining that "TRY200" is not acceptable for the `tool.ruff.lint` schema. From the ruff docs: https://docs.astral.sh/ruff/rules/reraise-no-cause/ > This rule has been removed and its documentation is only available for historical reasons. > > This rule is identical to [B904](https://docs.astral.sh/ruff/rules/raise-without-from-inside-except/) which should be used instead. and we are currently explicitly ignoring B904. Pull Request resolved: pytorch#126256 Approved by: https://github.com/Skylion007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My TOML linter is complaining that "TRY200" is not acceptable for the
tool.ruff.lintschema.From the ruff docs: https://docs.astral.sh/ruff/rules/reraise-no-cause/
and we are currently explicitly ignoring B904.
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire