Introduce test skip markers for Sandcastle #126273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
requested review from
mruberry,
lezcano,
nikitaved,
IvanYashchuk and
a team
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126273
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ebd2123 with merge base 2f53747 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
oncall: distributed
Simplify the markers a bit to make them more expressive
Flamefire
force-pushed
the
sandcastle-skip-markers
branch
from
332bd75
to
d05b98e
Compare
Flamefire
force-pushed
the
sandcastle-skip-markers
branch
from
043b325
to
bf1db1d
Compare
mikaylagawarecki
added
the
triaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the markers a bit to make them more expressive
It also makes it easier to skip those tests "manually" by changing the single definition of the skip marker.
This is important to reduce potential false positives (of failed tests) in some environments, such as HPC clusters
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k