-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate runtime asserts when propagate real tensor is used #126287
Conversation
This means that propagate real tensor is no longer unsound: if the route we took at compile time diverges with runtime, you will get a runtime assert. Also add structured trace logs for these. Also fix bug where xreplace with int range is not guaranteed to return a sympy expression. Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: e422e8aaf241ca15fe567d3a71cf52235193b276 Pull Request resolved: #126287
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_8-cuda12_1-test / test Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 0 checks: Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This means that propagate real tensor is no longer unsound: if the route we took at compile time diverges with runtime, you will get a runtime assert. Also add structured trace logs for these. Also fix bug where xreplace with int range is not guaranteed to return a sympy expression. Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: 4b5bfa3b67021b768a20cf4c7f1d065562e78744 Pull Request resolved: #126287
@pytorchbot merge |
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
This means that propagate real tensor is no longer unsound: if the route we took at compile time diverges with runtime, you will get a runtime assert. Also add structured trace logs for these. Also fix bug where xreplace with int range is not guaranteed to return a sympy expression. Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: a78dab39757b64d5ad262b9a28ea2e6c2d94a4e3 Pull Request resolved: #126287
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamo_eager_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge -i |
@pytorchbot merge -f "unrelated failures" |
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…126287) This means that propagate real tensor is no longer unsound: if the route we took at compile time diverges with runtime, you will get a runtime assert. Also add structured trace logs for these. Also fix bug where xreplace with int range is not guaranteed to return a sympy expression. Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#126287 Approved by: https://github.com/Skylion007
Stack from ghstack (oldest at bottom):
This means that propagate real tensor is no longer unsound: if the
route we took at compile time diverges with runtime, you will get a
runtime assert.
Also add structured trace logs for these.
Also fix bug where xreplace with int range is not guaranteed to return
a sympy expression.
Signed-off-by: Edward Z. Yang ezyang@meta.com