Warn SDPA users about dropout behavior #126294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126294
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 46c7a0c with merge base c53e0ac ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jbschlosser
added a commit
that referenced
this pull request
May 15, 2024
ghstack-source-id: e9f67213ad3dda32e7289f377ae0d9d443fd1b8e Pull Request resolved: #126294
mikaylagawarecki
approved these changes
May 15, 2024
torch/nn/functional.py
Outdated
Comment on lines
5021
to
5022
| This function always applies dropout according to the specified `dropout_p` argument. | ||
| To disable dropout during evaluation, be sure to pass a value of `0.0` when the module |
There was a problem hiding this comment.
nit:
Suggested change
| This function always applies dropout according to the specified `dropout_p` argument. | |
| To disable dropout during evaluation, be sure to pass a value of `0.0` when the module | |
| This function always applies dropout according to the specified ``dropout_p`` argument. | |
| To disable dropout during evaluation, be sure to pass a value of ``0.0`` when the module |
drisspg
approved these changes
May 15, 2024
jbschlosser
added
release notes: nn
Fixes #124464 TBD: validate formatting [ghstack-poisoned]
jbschlosser
added a commit
that referenced
this pull request
May 15, 2024
ghstack-source-id: 2178c8f373a4a58b9d9ab03c3762fa008cedf264 Pull Request resolved: #126294
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ZelboK
pushed a commit
to ZelboK/pytorch
that referenced
this pull request
May 19, 2024
Fixes pytorch#124464 Pull Request resolved: pytorch#126294 Approved by: https://github.com/mikaylagawarecki, https://github.com/drisspg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #124464