Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3 storage setup for snapshots, fixes #4109 #4151

Closed

Conversation

abhishek818
Copy link
Contributor

WIP
fixes: #4109

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@abhishek818 abhishek818 marked this pull request as draft May 1, 2024 04:55
@abhishek818 abhishek818 marked this pull request as ready for review May 1, 2024 18:47
@abhishek818 abhishek818 changed the title initial s3 storage setup for snapshots, fixes #4109 s3 storage setup for snapshots, fixes #4109 May 1, 2024
@generall
Copy link
Member

closing in favor of #4150

@generall generall closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants