Remove pointer alignment checks redundant since Rust 1.78

[timvisee]

We have some pointer alignment checks which are now redundant since the release of Rust 1.78.

Release notes: https://blog.rust-lang.org/2024/05/02/Rust-1.78.0.html#asserting-unsafe-preconditions

Same assertion shown in the standard library: https://doc.rust-lang.org/src/core/slice/raw.rs.html#95

All Submissions:

• Contributions should target the dev branch. Did you create your branch from dev?
• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

1. Does your submission pass tests?
2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
3. Have you checked your code using cargo clippy --all --all-features command?

[ffuugoo]

Our assertions are more informative, so I'd still leave them. But PR itself is LGTM.

[timvisee]

Our assertions are more informative, so I'd still leave them. But PR itself is LGTM.

That's true, though I don't expect to hit them again. If we get a panic from this later we can easily point to it and add it back if desired.

I'm just not super happy about doing this check twice, also because it makes those functions twice as big.

Wdyt? Keep or remove?

[ffuugoo]

Our assertions are more informative, so I'd still leave them. But PR itself is LGTM.

That's true, though I don't expect to hit them again. If we get a panic from this later we can easily point to it and add it back if desired.

I'm just not super happy about doing this check twice, also because it makes those functions twice as big.

Wdyt? Keep or remove?

Personally, I'd leave them. But I'm fine either way.

[timvisee]

Two people I asked both preferred to leave the extra checks, so I'm closing this issue