-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReshardingOperation::Start
consensus message
#4238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 14, 2024
ffuugoo
force-pushed
the
add-start-resharding-consensus-message
branch
2 times, most recently
from
May 16, 2024 09:14
b99daf7
to
9452435
Compare
ffuugoo
commented
May 16, 2024
timvisee
reviewed
May 16, 2024
lib/collection/src/collection/mod.rs
Outdated
Comment on lines
657
to
662
pub async fn start_resharding( | ||
&self, | ||
peer_id: PeerId, | ||
shard_id: ShardId, | ||
) -> CollectionResult<()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually we probably want to extend this to allow more shard configurations, but we can do that then.
timvisee
reviewed
May 17, 2024
generall
reviewed
May 17, 2024
generall
reviewed
May 17, 2024
timvisee
force-pushed
the
add-start-resharding-consensus-message
branch
from
May 17, 2024 11:51
a04ddd8
to
9cdb02d
Compare
generall
approved these changes
May 17, 2024
generall
pushed a commit
that referenced
this pull request
May 26, 2024
Co-authored-by: timvisee <tim@visee.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked in #4213.
This PR adds
ReshardingOperation::Start
consensus message. And also (in the most trivial way) disables splitting read operations to the resharding shard.Important TODO to be fixed in some future PR: consensus snapshot does not handle resharding in any way yet.
All Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
cargo +nightly fmt --all
command prior to submission?cargo clippy --all --all-features
command?Changes to Core Features: