Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

universal-query: Test and fix PlannedQuery conversion #4242

Merged
merged 3 commits into from
May 16, 2024
Merged

universal-query: Test and fix PlannedQuery conversion #4242

merged 3 commits into from
May 16, 2024

Conversation

coszio
Copy link
Contributor

@coszio coszio commented May 14, 2024 •
edited

Needs #4245

  • Tests and fixes the TryFrom<ShardQueryRequest> for PlannedQuery implementation
  • Adds ScoringQuery::Rrf variant

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@coszio coszio force-pushed the connect-grpc-internal-query-service branch from 9541579 to fb7072c Compare May 15, 2024 13:39
This was referenced May 15, 2024
Merged
Open
Base automatically changed from connect-grpc-internal-query-service to dev May 15, 2024 15:53
@coszio coszio force-pushed the test-shard-query-to-planned-query branch from b0619bf to d5868af Compare May 15, 2024 16:57
@coszio coszio changed the base branch from dev to restructure-universal-query-mod May 15, 2024 16:57
Base automatically changed from restructure-universal-query-mod to dev May 15, 2024 18:52
@coszio coszio force-pushed the test-shard-query-to-planned-query branch from 54866ce to 164c3cb Compare May 15, 2024 20:06
@coszio coszio requested review from agourlay and timvisee May 15, 2024 20:06
@coszio coszio marked this pull request as ready for review May 15, 2024 20:06
@coszio coszio changed the title universal-query: Test and fix PlannedQuery conversion universal-query: Test and fix PlannedQuery conversion May 15, 2024
agourlay
agourlay reviewed May 16, 2024
View reviewed changes
lib/collection/src/operations/universal_query/planned_query.rs
@@ -131,8 +162,8 @@ fn recurse_prefetches(
params,
limit,
offset: 0,
with_payload: None,
with_vector: None,
with_payload: Some(WithPayloadInterface::Bool(false)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None is not good enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured it would be better to make it explicit :)

@coszio coszio merged commit 7dcdae0 into dev May 16, 2024
17 checks passed
@coszio coszio deleted the test-shard-query-to-planned-query branch May 16, 2024 14:33
generall pushed a commit that referenced this pull request May 26, 2024
@coszio @generall
universal-query: Test and fix PlannedQuery conversion (#4242)
914b19f 
* test and fix PlannedQuery conversion

* add `ScoringQuery::RRF`

* add more test cases, fix more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agourlay agourlay agourlay approved these changes

@timvisee timvisee timvisee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coszio @agourlay @timvisee