Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix arm linking error on docker #4244

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

IvanPleshkov
Copy link
Contributor

@IvanPleshkov IvanPleshkov requested a review from ffuugoo May 15, 2024 13:04
Copy link
Contributor

@coszio coszio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this warning go away too 👍

warning: segment@0.6.0: NEON FP16 support detected. Enabling feature `neon_fp16`.

@generall generall merged commit 5d503b5 into dev May 15, 2024
17 checks passed
@generall generall deleted the fix-arm-linking-error-on-docker branch May 15, 2024 18:51
@TheQuantumFractal
Copy link
Contributor

TheQuantumFractal commented May 20, 2024

Heads up this change disables all the half precision neon SIMD implementations. The code removed was used to detect float16 support and enable SIMD operations in that case (half precision float operations introduced in arm v8.2). Without these flags, the vectors are converted to float32 then processed via float32 SIMD operations which can be slow.

generall pushed a commit that referenced this pull request May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants