Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an OLED black theme #787

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rstanuwijaya
Copy link

Added an OLED black theme (for OLED display)

image

Copy link
Contributor

@BirdInFire BirdInFire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a disclaimer this review only talk about the code itself not the "idea" of oled version (which will be stated later in "conversation").

I actually find a major issue witch make me ask the refusal (if not modified) is the fact that this actual code will do nothing (as not loaded anywhere), and if a change is made to load it, it will override the normal dark theme.

So my request is :

make a change to trigger it with an optional about:config settings
add it in a way it's actually loaded by the theme.
add a change in the readme to document the feature

@BirdInFire
Copy link
Contributor

So now my "PERSONAL" stance is : I don't really see the benefit of an oled version as libadwaita do not propose this actual "oled" color scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants