Base distributed_kv_stm_tests on raft fixture #18425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since list() returns kv_data_t it would make sense to make it public
bashtanov
force-pushed
the
base-distributed_kv_stm_tests-on-raft_fixture
branch
from
b7c47cb
to
67f534a
Compare
|
/dt |
Create a raft stm fixture, make distributed_kv_stm_tests and id_allocator_stm_test use it
bashtanov
force-pushed
the
base-distributed_kv_stm_tests-on-raft_fixture
branch
from
67f534a
to
bc9c4f0
Compare
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/49084#018f7686-09a9-49a8-8395-1d6ca49f2ba8 |
mmaslankaprv
approved these changes
May 14, 2024
bharathv
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of deprecating simple_raft_fixture in favour of
raft_fixture, makingdistributed_kv_stm_teststo use the latter.To avoid code duplication here and in future when porting further tests, a new test fixture template was created. It is a raft fixture equipped with one or multiple replicated STMs, and it provides a helper function to call STM functions on the leader node.
A minor change was made to the tested code in a separate commit.
Backports Required
Release Notes