Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix paligemma-client #397

Merged
merged 4 commits into from
May 16, 2024
Merged

Bugfix paligemma-client #397

merged 4 commits into from
May 16, 2024

Conversation

probicheaux
Copy link
Collaborator

Description

Fix IMAGE_PATH in client

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

local

Any specific deployment considerations

no

Docs

  • Docs updated? What were the changes:

@@ -3,7 +3,8 @@
import os

PORT = 9001
API_KEY = os.environ["API_KEY"]
# API_KEY = os.environ["API_KEY"]
API_KEY = "yqoRhbDSjh25rkRRkmbL"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to revoke

@PawelPeczek-Roboflow
Copy link
Collaborator

Could u also take a look at docs build failing on new modules https://github.com/roboflow/inference/actions/runs/9099684944/job/25012807735

@probicheaux probicheaux requested a review from yeldarby May 16, 2024 06:40
@PawelPeczek-Roboflow
Copy link
Collaborator

Could u inject the key into GHA secrets?

@probicheaux
Copy link
Collaborator Author

This is an example script to be used as a client

@PawelPeczek-Roboflow
Copy link
Collaborator

yeah, but I guess u revoked key and now CI fails on 403

@PawelPeczek-Roboflow
Copy link
Collaborator

I do not have access to the project

@probicheaux
Copy link
Collaborator Author

yeah, but I guess u revoked key and now CI fails on 403

Oh, I see now. Yep will fix

Copy link
Collaborator

@PawelPeczek-Roboflow PawelPeczek-Roboflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@probicheaux probicheaux merged commit e635a05 into main May 16, 2024
50 checks passed
@probicheaux probicheaux deleted the bugfix/paligemma-client branch May 16, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants