Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add draggable_scrollable_controller #417

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dickermoshe
Copy link

@dickermoshe dickermoshe commented Feb 25, 2024

Added useDraggableScrollableController with tests

Didn't edit readme or changelog
Lmk if you want the tests changed

@davidmartos96
Copy link
Contributor

I'd say this hook would benefit from the changes in #415

Current implementation of useDraggableScrollableController is not disposing the DraggableScrollableController.

@dickermoshe
Copy link
Author

@davidmartos96 Good point!
I copied this from Expandable tile controller. I forgot that that isn't disposed.
I'll fix later

@dickermoshe
Copy link
Author

dickermoshe commented Feb 26, 2024

Fixed dispose issue
If @rrousselGit plans on merging #415 I'll rebase and push

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (d53783b) to head (f4f8d62).

Current head f4f8d62 differs from pull request most recent head 47eaa1e

Please upload reports for the commit 47eaa1e to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
+ Coverage   98.36%   98.38%   +0.02%     
==========================================
  Files          21       22       +1     
  Lines         854      868      +14     
==========================================
+ Hits          840      854      +14     
  Misses         14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@rrousselGit rrousselGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after a little format change :)

Copy link
Owner

@rrousselGit rrousselGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, could you add it to the README? And the changelog too, under the form of:

## Unreleased patch

- Added <...>

@dickermoshe
Copy link
Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants