[xla:spmd] Fix a problem in generating code for concat that requires padding. #67586
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
exported_pr_633692857
branch
5 times, most recently
from
f10bd15
to
362d37b
Compare
…padding. When an internal concat operand requires padding, previously, we don't zero out the padded elements and the generated code produces incorrect results. Fix two existing tests. PiperOrigin-RevId: 634066344
copybara-service
bot
force-pushed
the
exported_pr_633692857
branch
from
362d37b
to
6a51996
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[xla:spmd] Fix a problem in generating code for concat that requires padding.
When an internal concat operand requires padding, previously, we don't zero out
the padded elements and the generated code produces incorrect results.
Fix two existing tests.