Address tfjs-node typos in documentation strings #8193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsoulanille
approved these changes
Mar 4, 2024
Comment on lines
-125
to
+133
| 'pool test-tensorflow {} max x=[3,3,1] f=[3,3] s=3 d=1 p=explicit defualt dimRoundingMode', | ||
| 'pool test-tensorflow {} max x=[3,3,1] f=[3,3] s=3 d=1 p=explicit default dimRoundingMode', | ||
| // tslint:disable-next-line:max-line-length | ||
| 'pool test-tensorflow {} max x=[3,3,1] f=[3,3] s=3 d=1 p=explicit dimRoundingMode=floor', | ||
| // tslint:disable-next-line:max-line-length | ||
| 'pool test-tensorflow {} max x=[3,3,1] f=[3,3] s=3 d=1 p=explicit dimRoundingMode=round', | ||
| // tslint:disable-next-line:max-line-length | ||
| 'pool test-tensorflow {} max x=[3,3,1] f=[3,3] s=3 d=1 p=explicit dimRoundingMode=ceil', | ||
| // tslint:disable-next-line:max-line-length | ||
| 'pool test-tensorflow {} avg x=[3,3,1] f=[3,3] s=3 d=1 p=explicit defualt dimRoundingMode', | ||
| 'pool test-tensorflow {} avg x=[3,3,1] f=[3,3] s=3 d=1 p=explicit default dimRoundingMode', |
There was a problem hiding this comment.
These test names may need to be updated in tfjs-core as well, or they might not be excluded in the tfjs-node tests.
There was a problem hiding this comment.
Hi, @mattsoulanille, @gbaned
I apologize for the delayed response and I have updated test names in tfjs-core, please refer this PR #8184 and I appreciate your time and look forward to your feedback. Thank you.
|
Hi @gaikwadrahul8 Can you please check above @mattsoulanille's comment? Thank you! |
pyu10055
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Team
I've identified and corrected several typos within the documentation strings (code comments) of
.tsfiles in thetfjs-nodefolder. I believe these corrections will improve the clarity and accuracy of the documentation for users. I appreciate your time and look forward to your feedback. Thank you.