Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Update JWT auth documentation to use PyJWT instead of pyhon-jose #11589

Merged
merged 6 commits into from
May 20, 2024
Merged

📝 Update JWT auth documentation to use PyJWT instead of pyhon-jose #11589

merged 6 commits into from
May 20, 2024

Conversation

estebanx64
Copy link
Collaborator

No description provided.

@tiangolo
Copy link
Owner

📝 Docs preview for commit 5a68592 at: https://604f2b88.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

📝 Docs preview for commit f252dc6 at: https://d2e11754.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

📝 Docs preview for commit 6734f79 at: https://ac0fd867.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

📝 Docs preview for commit 6734f79 at: https://0c8011f7.fastapitiangolo.pages.dev

@alejsdev alejsdev added the docs Documentation about how to use FastAPI label May 18, 2024
YuriiMotov
YuriiMotov suggested changes May 18, 2024
View reviewed changes
Copy link
Contributor

@YuriiMotov YuriiMotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is perfect except one small mistake with code line highlighting.

docs/en/docs/advanced/security/oauth2-scopes.md Outdated Show resolved Hide resolved
yezz123
yezz123 approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@yezz123 yezz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @YuriiMotov mentioned, everything is amazing, especially with the non-maintenance of python-jose. Therefore, pyjwt is the best alternative.

LGTM 🚀

@estebanx64 @YuriiMotov
Fix oauth2 scopes highlight example
875c025 
Co-authored-by: Motov Yurii <109919500+YuriiMotov@users.noreply.github.com>
@tiangolo
Copy link
Owner

📝 Docs preview for commit 875c025 at: https://83636c12.fastapitiangolo.pages.dev

YuriiMotov
YuriiMotov approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@YuriiMotov YuriiMotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good!
I paid special attention to highlighting the lines of code in all code blocks.
I also checked that all the necessary documentation pages have been corrected.

@estebanx64
Copy link
Collaborator Author

YuriiMotov

Thank you for your time and help

@tiangolo
Copy link
Owner

Awesome, thank you @estebanx64! 🚀 🍰

And thanks for the reviews @yezz123 and @YuriiMotov, in particular for checking carefully the highlighting, there was a lot of that. 😅 😎

Thanks!

@tiangolo tiangolo enabled auto-merge (squash) May 20, 2024 17:34
@tiangolo tiangolo merged commit 5fa8e38 into master May 20, 2024
44 checks passed
@tiangolo tiangolo deleted the FL-379-pyjwt-docs branch May 20, 2024 17:37
@hasansezertasan
Copy link
Contributor

Related: #9587

chrysremes added a commit to raianeli25/tech_challenge_1 that referenced this pull request May 23, 2024
@chrysremes
Removed Warning: python-jose is deprecated and has been replaced by p…
d85fd64 
…yjwt. See:

tiangolo/fastapi#11589
https://fastapi.tiangolo.com/tutorial/security/oauth2-jwt/#install-pyjwt
@dvdalilue dvdalilue mentioned this pull request May 23, 2024
Merged
hsuanchi pushed a commit to hsuanchi/fastapi that referenced this pull request May 26, 2024
@estebanx64 @YuriiMotov
@tiangolo @hsuanchi
📝 Update JWT auth documentation to use PyJWT instead of pyhon-jose (t…
453894b 
…iangolo#11589)

Co-authored-by: Motov Yurii <109919500+YuriiMotov@users.noreply.github.com>
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yezz123 yezz123 yezz123 approved these changes

@YuriiMotov YuriiMotov YuriiMotov approved these changes

Assignees
No one assigned
Labels
docs Documentation about how to use FastAPI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@estebanx64 @tiangolo @hasansezertasan @yezz123 @YuriiMotov @alejsdev