Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add administrator feature #6995

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

forehalo
Copy link
Member

No description provided.

Copy link

graphite-app bot commented May 20, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

forehalo commented May 20, 2024

@github-actions github-actions bot added app:server test Related to test cases labels May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.34%. Comparing base (02f7c46) to head (d3a93bc).

Additional details and impacted files
@@                       Coverage Diff                        @@
##           61/runtime-application-settings    #6995   +/-   ##
================================================================
  Coverage                            39.34%   39.34%           
================================================================
  Files                                  415      415           
  Lines                                 7904     7904           
  Branches                              1323     1323           
================================================================
  Hits                                  3110     3110           
  Misses                                4565     4565           
  Partials                               229      229           
Flag Coverage Δ
unittest 39.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forehalo forehalo force-pushed the 61/runtime-application-settings branch from da92936 to 57e8da5 Compare May 21, 2024 01:04
@forehalo forehalo force-pushed the 61/admin-feature branch 2 times, most recently from ee79459 to 4649c5d Compare May 21, 2024 02:27
@forehalo forehalo force-pushed the 61/runtime-application-settings branch from 57e8da5 to ae40517 Compare May 21, 2024 05:50
@forehalo forehalo marked this pull request as ready for review May 21, 2024 05:52
@forehalo forehalo force-pushed the 61/admin-feature branch 2 times, most recently from 6f1b167 to 5595d1e Compare May 21, 2024 07:03
@forehalo forehalo force-pushed the 61/runtime-application-settings branch from ae40517 to 264ce92 Compare May 21, 2024 08:44
@forehalo forehalo force-pushed the 61/admin-feature branch 2 times, most recently from 7cff6b1 to 0e5d032 Compare May 21, 2024 09:54
@forehalo forehalo force-pushed the 61/runtime-application-settings branch from 264ce92 to fd0c4e1 Compare May 22, 2024 09:30
@forehalo forehalo force-pushed the 61/runtime-application-settings branch from fd0c4e1 to bd2ee8a Compare May 22, 2024 09:32
@forehalo forehalo force-pushed the 61/runtime-application-settings branch from bd2ee8a to fb40cf1 Compare May 22, 2024 09:34
@forehalo forehalo force-pushed the 61/runtime-application-settings branch from fb40cf1 to 70594bd Compare May 22, 2024 09:35
@forehalo forehalo force-pushed the 61/runtime-application-settings branch from 70594bd to 02f7c46 Compare May 22, 2024 09:52
@forehalo forehalo force-pushed the 61/runtime-application-settings branch from 02f7c46 to a3b3b7b Compare May 24, 2024 02:37
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

Attention: Patch coverage is 73.01587% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 67.02%. Comparing base (5ba9e2e) to head (aff166a).

Files Patch % Lines
...kages/backend/server/src/core/features/resolver.ts 54.28% 16 Missing ⚠️
...ages/backend/server/src/core/common/admin-guard.ts 75.00% 12 Missing and 1 partial ⚠️
...ges/backend/server/src/core/features/management.ts 65.38% 9 Missing ⚠️
...ages/backend/server/src/plugins/payment/service.ts 58.82% 7 Missing ⚠️
packages/backend/server/src/core/user/resolver.ts 40.00% 3 Missing ⚠️
...ckages/backend/server/src/core/features/service.ts 50.00% 2 Missing ⚠️
packages/backend/server/src/core/auth/service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6995      +/-   ##
==========================================
+ Coverage   66.98%   67.02%   +0.03%     
==========================================
  Files         586      589       +3     
  Lines       28953    28899      -54     
  Branches     2615     2604      -11     
==========================================
- Hits        19395    19370      -25     
+ Misses       9286     9256      -30     
- Partials      272      273       +1     
Flag Coverage Δ
server-test 77.56% <73.01%> (+0.08%) ⬆️
unittest 39.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forehalo forehalo changed the base branch from 61/runtime-application-settings to canary May 27, 2024 07:56
Copy link

graphite-app bot commented May 27, 2024

Merge activity

@graphite-app graphite-app bot merged commit aff166a into canary May 27, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 61/admin-feature branch May 27, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:server test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

5 participants