-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Convert to TypeScript and Svelte #584
Draft
tuanchauict
wants to merge
124
commits into
main
Choose a base branch
from
port-to-js
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, LiveData is Flow
…he target element
except drawCrossingPoints
[WIP] Convert Board to TS
Replace prettier with eslint
mimic from Kotlin
Implement draw crossing point
Add drawable and its child classes
Implement BrowserManager and WorkspaceDao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although Kotlin JS is super good for development and nothing wrong when adding new features, the UI is a big bottleneck when I want to support more tools.
As you can see, the shape format tool is limited and (TBH) ugly.
Although MonoSketch already adopted Compose HTML, I still feel it's not right to use code for creating UI.
Maybe I'm an old-fashion guy, but XML seems to be the best language for UI, IMO.
After considering back and forth, tradeoffs, and efforts, I decided to convert the project into TypeScript and use Svelte for the UI.
I tried to make Kotlin JS and Svelte living under the same project but it was not as good as I expected. Both want to be the last guy in the room, or, in other words, need to be the last thing to be compiled. Creating and maintaining the bridge will be the other bottleneck, which I cannot afford.