Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugins cache #3729

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix plugins cache #3729

wants to merge 1 commit into from

Conversation

kaixi-wang
Copy link
Contributor

What changes are proposed in this pull request?

(Please fill in changes proposed in this fix)

How is this patch tested? If it is not, please explain why.

(Details)

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@kaixi-wang kaixi-wang self-assigned this Oct 27, 2023
Copy link
Contributor

@ritch ritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test? Need to test plugins at a few levels as they can be grouped in a dir or at the root.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (146059f) 16.23% compared to head (09fc555) 16.23%.
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3729      +/-   ##
===========================================
- Coverage    16.23%   16.23%   -0.01%     
===========================================
  Files          640      640              
  Lines        74260    74254       -6     
  Branches       988      988              
===========================================
- Hits         12058    12052       -6     
  Misses       62202    62202              
Flag Coverage Δ
app 16.23% <64.10%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pp/packages/relay/src/fragments/datasetFragment.ts 100.00% <100.00%> (ø)
app/packages/state/src/recoil/groups.ts 59.34% <100.00%> (-0.66%) ⬇️
app/packages/state/src/recoil/selectors.ts 51.14% <100.00%> (ø)
app/packages/state/src/recoil/types.ts 100.00% <100.00%> (ø)
...es/core/src/components/Actions/similar/Similar.tsx 0.00% <0.00%> (ø)
...kages/core/src/components/Actions/similar/utils.ts 0.00% <0.00%> (ø)
...pp/packages/app/src/pages/datasets/DatasetPage.tsx 0.00% <0.00%> (ø)
...ore/src/components/Actions/similar/GroupButton.tsx 0.00% <0.00%> (ø)
app/packages/state/src/recoil/utils.ts 68.39% <27.27%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants