Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding config setting to disable singleton cache #3956

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Dec 22, 2023

Example usage

import fiftyone as fo

fo.config.singleton_cache = False

dataset = fo.Dataset()
sample = fo.Sample(filepath="image.jpg")

dataset.add_sample(sample)
print(sample.in_dataset)  # True

also_sample = dataset.first()
print(sample is also_sample)  # False

also_dataset = fo.load_dataset(dataset.name)
print(also_dataset is dataset)  # False

TODO

When singleton caching is disabled, there are a variety of places where patterns like this are used where the reload() is now always unnecessary:

dataset = fo.load_dataset(name)
dataset.reload()  # reload in case we got a singleton rather than a refresh load from the database

We should probably refactor those calls into a single method call so that unnecessary reloads can be skipped:

# Reload the dataset (only) if a singleton instance was returned
dataset = fo.load_dataset(name, reload=True)

@brimoor brimoor self-assigned this Dec 22, 2023
@brimoor brimoor added the enhancement Code enhancement label Dec 22, 2023
@brimoor brimoor marked this pull request as draft December 22, 2023 23:28
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c018ed) 15.85% compared to head (9ad6b78) 15.85%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3956   +/-   ##
========================================
  Coverage    15.85%   15.85%           
========================================
  Files          731      731           
  Lines        81886    81886           
  Branches      1093     1093           
========================================
  Hits         12987    12987           
  Misses       68899    68899           
Flag Coverage Δ
app 15.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant